make sure all non-cli broadcasts use broadcast config param #8892
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
Wozacosta
force-pushed
the
chore/future-proof-mevprotection-onbroadcast
branch
from
c686b18 to
b253cfb
Compare
Wozacosta
force-pushed
the
chore/future-proof-mevprotection-onbroadcast
branch
from
b253cfb to
9d82aa6
Compare
LucasWerey
previously approved these changes
Jan 17, 2025
Wozacosta
dismissed stale reviews from LucasWerey and ComradeAERGO
via
4cba060
Justkant
reviewed
Jan 17, 2025
| @@ -70,6 +72,7 @@ export const broadcastTransactionLogic = ( | |||
| ): Promise<string> => { | |||
| const bridge = getAccountBridge(account, parentAccount); | |||
| const mainAccount = getMainAccount(account, parentAccount); | |||
| const mevProtected = useSelector(mevProtectionSelector); | |||
There was a problem hiding this comment.
I wouldn't use a useSelector in here if possible, it's not a react component and we cannot expect it to work correctly in all cases
There was a problem hiding this comment.
You would probably want to add this in the WebPlatformContext
ComradeAERGO
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Mobile update:
mev protection wouldn't be used for now, but if in the future we use the
useSignWithDevicehook elsewhere where mev protection would make sense, it'll be there.Desktop udpate:
LiveAppSDKLogic <- PlatformAPIWebView <-Web3AppWebview/index.tsx
<- apps/ledger-live-desktop/src/renderer/components/WebPTXPlayer/index.tsx (used only be LiveAppCard and Buy/Sell)
<- apps/ledger-live-desktop/src/renderer/components/WebPlatformPlayer/index.tsx (only important one here, handle legacy manifests live-app, earn)
<- apps/ledger-live-desktop/src/renderer/components/WebRecoverPlayer/index.tsx
<- apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/SwapWebViewDemo3.tsx
❓ Context
🧐 Checklist for the PR Reviewers